Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base #57864

Merged
merged 5 commits into from
Oct 9, 2023
Merged

[CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base #57864

merged 5 commits into from
Oct 9, 2023

Conversation

Kaedeharai
Copy link
Contributor

PR types

Others

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented Oct 3, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 3, 2023
from .proto import data_feed_pb2 # noqa: F401
from .proto import framework_pb2
from .variable_index import _getitem_static, _setitem_impl_, _setitem_static
from .wrapped_decorator import signature_safe_contextmanager, wrap_decorator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C408 没有 import 检查,还原一下

@Kaedeharai
Copy link
Contributor Author

@gouzil麻烦大佬看下,还需要改成什么样子啊

@gouzil
Copy link
Member

gouzil commented Oct 9, 2023

LGTM, PR-CI-Model-benchmark需要 rerun, @SigureMo

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 9, 2023
@luotao1 luotao1 merged commit aa277a5 into PaddlePaddle:develop Oct 9, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
…lePaddle#57864)

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
…lePaddle#57864)

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base
@Kaedeharai Kaedeharai deleted the Kaedeharai branch October 17, 2023 08:50
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…lePaddle#57864)

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base

* [CodeStyle][task 8] enable Ruff C408 rule in python/paddle/base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants