Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][task 30] enable ruff C411 rule in python/paddle/base #57707

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

longranger2
Copy link
Contributor

@longranger2 longranger2 commented Sep 25, 2023

PR types

Others

PR changes

Others

Description

enable ruff C411 rule in python/paddle/base

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 25, 2023
@gouzil
Copy link
Member

gouzil commented Sep 25, 2023

还有残留呀,注意现在的ruff版本为ruff 0.0.289

ruff check .
python/paddle/base/backward.py:763:5: C411 [*] Unnecessary `list` call (remove the outer call to `list()`)
Found 1 error.
[*] 1 potentially fixable with the --fix option.

@longranger2
Copy link
Contributor Author

@gouzil done

@gouzil
Copy link
Member

gouzil commented Sep 26, 2023

LGTM,@SigureMo

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit a526c18 into PaddlePaddle:develop Sep 27, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants