[xdoctest] reformat example code with google style in No.138 and 140 #57479

yuchen202 · 2023-09-19T05:14:53Z

PR types

Others

PR changes

Others

Description

修改如下文件的示例代码，使其通过 xdoctest 检查：

python\paddle\tensor\manipulation.py
python\paddle\tensor\search.py

Related links

paddle-bot · 2023-09-19T05:15:31Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

yuchen202 · 2023-09-19T05:19:46Z

我先改改，先不慌review

先浅改了一下下，请大佬帮我康康

luotao1 · 2023-09-26T09:47:26Z

我先改改，先不慌review

改完了么？

yuchen202 · 2023-09-26T09:48:29Z

可以review了，别的不会改了

…

---Original--- From: "Tao ***@***.***> Date: Tue, Sep 26, 2023 17:47 PM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [PaddlePaddle/Paddle] [xdoctest] reformat example code withgoogle style in No.138 and 140 (PR #57479) 我先改改，先不慌review 改完了么？ — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

megemini · 2023-09-26T11:40:35Z

python/paddle/tensor/manipulation.py

-            #        [[2., 2., 2.],
-            #         [1., 1., 1.],
-            #         [2., 2., 2.]])
+            >>> # required: gpu


改成 doctest 的样式～

megemini · 2023-09-26T11:41:02Z

python/paddle/tensor/manipulation.py

-            #        [[2., 1., 2.],
-            #         [2., 1., 2.],
-            #         [2., 1., 2.]])
+            >>> # required: gpu


改成 doctest 的样式～

>>> # doctest: +REQUIRES(env:GPU)

megemini · 2023-09-26T11:43:27Z

python/paddle/tensor/manipulation.py

-            out = paddle.flatten(img, start_axis=1, stop_axis=2)
-            # out shape is [2, 12, 4]
+            >>> out = paddle.flatten(img, start_axis=1, stop_axis=2)
+            >>> # out shape is [2, 12, 4]


>>> print(out.shape) [2, 12, 4]

megemini · 2023-09-26T11:44:15Z

python/paddle/tensor/manipulation.py

+            >>> print(out[0, 0, 0])
+            Tensor(shape=[1], dtype=int64, place=Place(cpu), stop_gradient=True,
+            [-1])


已经是 0D 的了

Tensor(shape=[], dtype=int64, place=Place(gpu:0), stop_gradient=True, -1)

megemini · 2023-09-26T11:46:12Z

python/paddle/tensor/manipulation.py

+            >>> # the shape of out_2 is [4, 12].
+            Tensor(shape=[4, 12], dtype=float32, place=Place(cpu), stop_gradient=True,
+            [[0.16556728, 0.98233348, 0.64653695, 0.68488085, 0.26045629, 0.32933319,
+              0.29747701, 0.85176629, 0.84460896, 0.86866283, 0.46335083, 0.33930254],
+             [0.42339125, 0.14102051, 0.69832194, 0.63159829, 0.91087127, 0.31725556,
+              0.09400324, 0.25861803, 0.26968575, 0.38659596, 0.25225133, 0.26315665],
+             [0.83726203, 0.33221707, 0.98031831, 0.38393897, 0.00512545, 0.04543629,
+              0.90596122, 0.70148915, 0.26110184, 0.55263036, 0.68636090, 0.67877120],
+             [0.60491085, 0.96849394, 0.08488113, 0.48084566, 0.61894107, 0.92885363,
+              0.37273413, 0.08096626, 0.74429852, 0.85212839, 0.60244918, 0.76718718]])


reshape 后的数据不对～ x 只是 shape 变了，数据应该不变的～

我看看啊

megemini · 2023-09-26T11:51:59Z

python/paddle/tensor/manipulation.py

+            Tensor(shape=[1], dtype=float64, place=Place(cpu), stop_gradient=True,
+            [285.])
+            >>> print(z2)
+            Tensor(shape=[1], dtype=float64, place=Place(cpu), stop_gradient=True,
+            [285.])


这里 Tensor 是 0D 的～

megemini · 2023-09-26T11:52:40Z

python/paddle/tensor/manipulation.py

+            [[0., 1.],
+             [4., 5.]]


这里是 Tensor ～

megemini · 2023-09-26T11:53:22Z

python/paddle/tensor/manipulation.py

+            >>> print(out1[0, 0, 0])
+            [10.]
+            >>> print(out2[0, 0, 0, 0])
+            [10.]
+            >>> print(out3[0, 0, 0, 0, 0])
+            [10.]


这里是 Tensor ～

megemini · 2023-09-26T11:55:25Z

python/paddle/tensor/manipulation.py

+            >>> import paddle
+            >>> paddle.base.set_flags({"FLAGS_use_stride_kernel": True})
+
+            >>> x = paddle.rand([2, 4, 6], dtype="float32")
+
+            >>> out = paddle.view(x, "uint8")
+            >>> print(out)


这里最好也加个 seed 重新看一下结果～

megemini · 2023-09-26T11:56:15Z

python/paddle/tensor/manipulation.py

+            >>> print(out)
+            Tensor(shape=[8, 6], dtype=float32, place=Place(cpu), stop_gradient=True,
+            [[0.23340422, 0.62036550, 0.12185233, 0.88982582, 0.61383390, 0.22415221],
+             [0.85698199, 0.87602723, 0.00502827, 0.92127788, 0.34579527, 0.85451263],
+             [0.68906647, 0.05126054, 0.25322226, 0.43883288, 0.49656981, 0.68857300],
+             [0.21424839, 0.99576813, 0.62306029, 0.48010525, 0.31222206, 0.48758999],
+             [0.35929242, 0.12802263, 0.80540675, 0.76783085, 0.84970695, 0.00389719],
+             [0.69256896, 0.73718327, 0.97155327, 0.50271672, 0.60357946, 0.59580350],
+             [0.68182445, 0.28539398, 0.13948134, 0.66333318, 0.72601736, 0.31108484],
+             [0.58283192, 0.89317679, 0.11751470, 0.04111906, 0.04056534, 0.75454420]])


这个结果跟 aistudio 上的不一样～需要确认一下～

应该还有一个文件要review@megemini

megemini · 2023-09-27T03:57:06Z

python/paddle/tensor/manipulation.py

+            Tensor(shape=[1], dtype=float32, place=Place(cpu), stop_gradient=True,
+            [10.])
            >>> print(out2[0, 0, 0, 0])
-            [10.]
+            Tensor(shape=[1], dtype=float32, place=Place(cpu), stop_gradient=True,
+            [10.])
            >>> print(out3[0, 0, 0, 0, 0])
-            [10.]
+            Tensor(shape=[1], dtype=float32, place=Place(cpu), stop_gradient=True,
+            [10.])


可以在 aistudio 上面验证一下，安装最新的 develop 版本：

python -m pip install paddlepaddle-gpu==0.0.0.post112 -f https://www.paddlepaddle.org.cn/whl/linux/gpu/develop.html

结果应该是 0D 而不是 1D ～

paddle-ci-bot · 2023-10-05T03:20:20Z

Sorry to inform you that 512559a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

python/paddle/tensor/search.py

SigureMo · 2023-10-10T11:42:43Z

python/paddle/tensor/manipulation.py

+            [[[[0.01787627, 0.76492310],
+               [0.67605734, 0.04620579],
+               [0.38763246, 0.96462214]],
+              [[0.62356627, 0.64948404],
+               [0.53736508, 0.09874519],
+               [0.47123933, 0.85700107]],
+              [[0.34647217, 0.62869102],
+               [0.54760450, 0.18061899],
+               [0.55075216, 0.71997911]],
+              [[0.78576684, 0.76743823],
+               [0.35644373, 0.63325852],
+               [0.26549375, 0.68052763]]],
+             [[[0.40971112, 0.95848298],
+               [0.41229674, 0.05506011],
+               [0.18543524, 0.63480365]],
+              [[0.81180859, 0.94548297],
+               [0.19634065, 0.73838711],
+               [0.42057949, 0.96017945]],
+              [[0.72278100, 0.93858665],
+               [0.72018963, 0.61661047],
+               [0.33307818, 0.86660689]],
+              [[0.55808324, 0.12933673],
+               [0.42916751, 0.22745337],
+               [0.60508877, 0.82193440]]]])


这里 reshape 的输出是没有必要的，可以

只打印 shape

或者使用较小的、arange 数据

下同，其他地方也需要修改

paddle-ci-bot · 2023-10-18T03:09:15Z

Sorry to inform you that 6820f97's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

luotao1 · 2023-10-19T07:40:12Z

close due to the following PR is merged:

[xdoctest][task 138 and 140] reformat example code with google style in audio/* #58189

[xdoctest] reformat example code with google style in No.356

987052f

Update search.py

436f46a

paddle-bot bot added the contributor External developers label Sep 19, 2023

luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Sep 20, 2023

luotao1 assigned luotao1, SigureMo and sunzhongkai588 Sep 20, 2023

Update manipulation.py

abfa027

先浅改了一下下，请大佬帮我康康

luotao1 mentioned this pull request Sep 26, 2023

[xdoctest] 分批次修改已有代码的示例 #55629

Closed

megemini reviewed Sep 26, 2023

View reviewed changes

Update manipulation.py

fdd9d0a

应该还有一个文件要review@megemini

megemini reviewed Sep 27, 2023

View reviewed changes

Update manipulation.py

512559a

SigureMo reviewed Oct 10, 2023

View reviewed changes

Apply suggestions from code review

6820f97

SigureMo reviewed Oct 10, 2023

View reviewed changes

luotao1 closed this Oct 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[xdoctest] reformat example code with google style in No.138 and 140 #57479

[xdoctest] reformat example code with google style in No.138 and 140 #57479

yuchen202 commented Sep 19, 2023

paddle-bot bot commented Sep 19, 2023

yuchen202 commented Sep 19, 2023

luotao1 commented Sep 26, 2023

yuchen202 commented Sep 26, 2023 via email

megemini Sep 26, 2023

megemini Sep 26, 2023

megemini Sep 26, 2023

megemini Sep 26, 2023

megemini Sep 26, 2023

yuchen202 Sep 26, 2023

megemini Sep 26, 2023

megemini Sep 26, 2023

megemini Sep 26, 2023

megemini Sep 26, 2023

megemini Sep 26, 2023

megemini Sep 27, 2023

paddle-ci-bot bot commented Oct 5, 2023

SigureMo Oct 10, 2023

paddle-ci-bot bot commented Oct 18, 2023

luotao1 commented Oct 19, 2023

[xdoctest] reformat example code with google style in No.138 and 140 #57479

[xdoctest] reformat example code with google style in No.138 and 140 #57479

Conversation

yuchen202 commented Sep 19, 2023

PR types

PR changes

Description

Related links

paddle-bot bot commented Sep 19, 2023

yuchen202 commented Sep 19, 2023

luotao1 commented Sep 26, 2023

yuchen202 commented Sep 26, 2023 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paddle-ci-bot bot commented Oct 5, 2023

Choose a reason for hiding this comment

paddle-ci-bot bot commented Oct 18, 2023

luotao1 commented Oct 19, 2023