Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xdoctest][task 144-149] reformat example code with google style in text/datasets/* #56579

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

ooooo-create
Copy link
Contributor

PR types

Others

PR changes

Others

Description

修改如下文件的示例代码,使其通过 xdoctest 检查:

  • python/paddle/text/datasets/conll05.py
  • python/paddle/text/datasets/imdb.py
  • python/paddle/text/datasets/imikolov.py
  • python/paddle/text/datasets/movielens.py
  • python/paddle/text/datasets/uci_housing.py
  • python/paddle/text/datasets/wmt14.py

预览:

Related links

@sunzhongkai588 @SigureMo @megemini

@SigureMo SigureMo changed the title [xdoctest][task 144-149] reformat example code with google style in /ext/datasets/* [xdoctest][task 144-149] reformat example code with google style in text/datasets/* Aug 23, 2023
@paddle-bot paddle-bot bot added the contributor External developers label Aug 23, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@megemini 为啥 timeout 了还是 successful 呢?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@megemini 为啥 timeout 了还是 successful 呢?

因为 #56573 这个 PR 还没合入 ~~~ 哈哈哈哈

之前旧代码的逻辑一直都是,timeout 只是提示,#56573 里面我觉得不合适,干脆改为 failed, timeout, nocode 都是错误~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nocode 的意思是不是就是说旧格式呢?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nocode 的意思是不是就是说旧格式呢?

nocode 目前有两种情况:

  • 旧格式的代码,因为,旧格式代码在 xdoctest 看来就是一堆描述文字,所以会 nocode。
  • 语法错误,因为,xdoctest 对于语法错误会 catch,但是直接 pass,最后的结果与 nocode 一样。

所以,具体情况还要看日志,不过,以上两种情况应该都是不合理的,所以最终应该认定为检查失败。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所以,具体情况还要看日志,不过,以上两种情况应该都是不合理的,所以最终应该认定为检查失败。

好的了解

@ooooo-create 调整一下两个 timeout 示例的时间吧

@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Aug 24, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit 700bc8c into PaddlePaddle:develop Aug 25, 2023
@ooooo-create ooooo-create deleted the ooooo/xdoctest144 branch August 31, 2023 10:19
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
…text/datasets/*` (PaddlePaddle#56579)

* [Doctest]fix No.144-149, test=docs_preview

* fix timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants