-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xdoctest][task 144-149] reformat example code with google style in text/datasets/*
#56579
Conversation
/ext/datasets/*
text/datasets/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@megemini 为啥 timeout 了还是 successful 呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nocode 的意思是不是就是说旧格式呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nocode 的意思是不是就是说旧格式呢?
nocode 目前有两种情况:
- 旧格式的代码,因为,旧格式代码在 xdoctest 看来就是一堆描述文字,所以会 nocode。
- 语法错误,因为,xdoctest 对于语法错误会 catch,但是直接 pass,最后的结果与 nocode 一样。
所以,具体情况还要看日志,不过,以上两种情况应该都是不合理的,所以最终应该认定为检查失败。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow 🐾
…text/datasets/*` (PaddlePaddle#56579) * [Doctest]fix No.144-149, test=docs_preview * fix timeout
PR types
Others
PR changes
Others
Description
修改如下文件的示例代码,使其通过
xdoctest
检查:python/paddle/text/datasets/conll05.py
python/paddle/text/datasets/imdb.py
python/paddle/text/datasets/imikolov.py
python/paddle/text/datasets/movielens.py
python/paddle/text/datasets/uci_housing.py
python/paddle/text/datasets/wmt14.py
预览:
Related links
@sunzhongkai588 @SigureMo @megemini