Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][CINN] fix cinn codestyle cmake-lint #54975

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Jun 29, 2023

PR types

Others

PR changes

Others

Description

fix cinn codestyle cmake-lint

@paddle-bot
Copy link

paddle-bot bot commented Jun 29, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 29, 2023
@SigureMo
Copy link
Member

按顺序先 exclude 吧,还是说确保这一个 PR 修复了全部的问题呢?

@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Jun 29, 2023

@SigureMo 这个PR修改了pre-commit run cmakelint --all-files 报错的24个代码风格错误,因为数量不多就一次全部改了,还需要先exclude嘛?

@SigureMo
Copy link
Member

等 cmake format 格式化合入后需要解决冲突

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 29, 2023
@SigureMo
Copy link
Member

SigureMo commented Jun 29, 2023

cmake-format 已经合入,麻烦 merge develop + 移除配置里的 exclude,更新一下 PR~

@SigureMo
Copy link
Member

啊 居然没有冲突,我看看,如果没什么问题就直接合了吧,然后新提一个 PR 把 exclude 项删掉

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit bbcaaff into PaddlePaddle:develop Jun 29, 2023
@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Jun 29, 2023

Done.

@ccsuzzh ccsuzzh deleted the fix_cinn_cmakelint branch June 29, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants