Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codestyle] fix cinn flake8 #54972

Closed
wants to merge 5 commits into from

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jun 28, 2023

PR types

Others

PR changes

Others

Description

修复 cinn 代码格式问题,仅修复 flask8

相关链接:
#54953

@paddle-bot
Copy link

paddle-bot bot commented Jun 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 28, 2023
@SigureMo
Copy link
Member

SigureMo commented Jun 28, 2023

black merge 后解决冲突后 review,建议按照流程来,现有流程是在最小冲突的前提上拆分任务的

@gouzil
Copy link
Member Author

gouzil commented Jun 28, 2023

black merge 后解决冲突后 review,建议按照流程来,现有流程是在最小冲突的前提上拆分任务的

#54974

@gouzil gouzil changed the title [codestyle] fix cinn flake8 ruff [codestyle] fix cinn flake8 Jun 28, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 29, 2023
@SigureMo
Copy link
Member

Flake8 的先不要做,会和 black 冲突,有很多在 black 格式化后就会消失,为什么不按照流程来呢?

@paddle-bot
Copy link

paddle-bot bot commented Jun 29, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@gouzil gouzil deleted the cinn_flake8_-ruff_fix branch August 1, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants