Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][CINN] format cpp code via clang-format #54961

Merged
merged 6 commits into from
Jun 29, 2023
Merged

[CodeStyle][CINN] format cpp code via clang-format #54961

merged 6 commits into from
Jun 29, 2023

Conversation

Ainavo
Copy link
Contributor

@Ainavo Ainavo commented Jun 28, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

clang-formatFormatter CINN 部分全量格式化

@paddle-bot
Copy link

paddle-bot bot commented Jun 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 28, 2023
@SigureMo
Copy link
Member

image

CI 中仍然失败，需要确认下是否格式化正确

@SigureMo SigureMo mentioned this pull request Jun 28, 2023
Closed
@Ainavo
Copy link
Contributor Author

Ainavo commented Jun 28, 2023

image CI 中仍然失败，需要确认下是否格式化正确

ok

@SigureMo SigureMo changed the title [CodeStyle][CINN] fix clang-format [CodeStyle][CINN] format cpp code via clang-format Jun 28, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 29, 2023
@SigureMo SigureMo self-requested a review June 29, 2023 07:23
SigureMo
SigureMo approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

clang-format 已通过 🎉

@luotao1 luotao1 merged commit af12734 into PaddlePaddle:develop Jun 29, 2023
@SigureMo SigureMo deleted the codestyle_cinn_clang-format branch June 29, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ainavo @SigureMo @luotao1