Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequence_mask functionalization #53478

Merged
merged 2 commits into from
May 12, 2023
Merged

sequence_mask functionalization #53478

merged 2 commits into from
May 12, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented May 1, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

sequence_mask functionalization

@paddle-bot
Copy link

paddle-bot bot commented May 1, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 1, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 1, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@GreatV GreatV mentioned this pull request May 8, 2023
Closed
@GreatV GreatV requested a review from From00 May 10, 2023 00:37
@GreatV
Copy link
Contributor Author

GreatV commented May 11, 2023

@From00 麻烦再次review一下。

From00
From00 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhwesky2010
zhwesky2010 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for rm unity_build_rule

@From00 From00 merged commit d2b1e3c into PaddlePaddle:develop May 12, 2023
@GreatV GreatV deleted the sequence_mask_functionalization branch May 12, 2023 08:00
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@From00 From00 From00 approved these changes

Assignees

@luotao1 luotao1

@From00 From00

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GreatV @From00 @YuanRisheng @zhwesky2010 @luotao1