Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fused feedforward #53166

Merged
merged 24 commits into from
Apr 27, 2023
Merged

Move fused feedforward #53166

merged 24 commits into from
Apr 27, 2023

Conversation

AndSonder
Copy link
Contributor

@AndSonder AndSonder commented Apr 21, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

迁移 fused feedforward fused feedforward grad GPU Op Kernel 迁移到 phi

因分布式相关头文件依赖：

#include "paddle/fluid/distributed/collective/process_group_nccl.h"
#include "paddle/fluid/platform/collective_helper.h"
#include "paddle/fluid/platform/device/gpu/nccl_helper.h"

此算子直接在fluid目录下迁移成函数式，后续分布式依赖迁移后，再将代码移动到PHI目录下。

相关 Issue:

[used AI Studio]

@paddle-bot
Copy link

paddle-bot bot commented Apr 21, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 21, 2023
@paddle-bot
Copy link

paddle-bot bot commented Apr 21, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@AndSonder AndSonder mentioned this pull request Apr 21, 2023
Closed
AndSonder and others added 21 commits April 21, 2023 06:11
@AndSonder
remove maxfunctor
b82a128
@AndSonder
move fused feedward to phi
b8dce23
@AndSonder
remove sig file
806b810
@AndSonder
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
17e2c83 
… move_fused_feedforward
@AndSonder
remove fliud include
4c7fbc5
@AndSonder
add include
9ae4109
@AndSonder
add include
7beaf4f
@AndSonder
add sig file
f2a2253
@AndSonder
add output register info
b671040
@AndSonder
fix sig file
1d48dc2
@AndSonder
Update fused_feedforward_sig.cc
1cd7503
@AndSonder
update sig
10f5807
@AndSonder
fix grad kernel
e1dd196
@AndSonder
update output register info
8a41b8c
@AndSonder
fix
fb233b3
@AndSonder
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
827969a 
… move_fused_feedforward
@AndSonder
open fused_feedforward static build
868bc1c
@AndSonder
add optional and fix code style
fac2a30
@AndSonder
fix output info for fused attention
547587e
@AndSonder
add optional param
9064f99
@AndSonder
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
c8c17bb 
… move_fused_feedforward
From00
From00 reviewed Apr 26, 2023
View reviewed changes
paddle/phi/kernels/fusion/gpu/fused_dropout_helper.h Outdated
@@ -30,6 +30,8 @@
#include "paddle/phi/kernels/fusion/gpu/fused_residual_dropout_bias.h"
#include "paddle/phi/kernels/layer_norm_kernel.h"

DECLARE_bool(use_fast_math);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为何需要引入use_fast_math？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是为了和 paddle/fluid/operators/fused/fused_dropout_helper.h 保持统一，这个文件我当时迁过来的时候没有加这一句，当时排查精度问题的时候加上的。但是这个好像和精度问题也没关系，由于原来 fluid 里面有我就留在那里了。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

若无实质作用，这里可以不需要再加上。

From00
From00 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 25b4ba7 into PaddlePaddle:develop Apr 27, 2023
@AndSonder AndSonder deleted the move_fused_feedforward branch April 23, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@From00 From00 From00 approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndSonder @From00