Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greater_equal API for fp16 #51098

Merged
merged 4 commits into from
Mar 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions python/paddle/fluid/tests/unittests/test_greater_equal_op.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


import unittest

import numpy as np

import paddle
import paddle.fluid.core as core
import paddle.static as static


class Test_Greater_Equal_Op_Fp16(unittest.TestCase):
def test_api_fp16(self):
paddle.enable_static()
with static.program_guard(static.Program(), static.Program()):
label = paddle.to_tensor([3, 3], dtype="float16")
limit = paddle.to_tensor([3, 2], dtype="float16")
out = paddle.greater_equal(x=label, y=limit)
if core.is_compiled_with_cuda():
place = paddle.CUDAPlace(0)
exe = static.Executor(place)
(res,) = exe.run(fetch_list=[out])
self.assertEqual((res == np.array([True, True])).all(), True)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前不推荐使用fluid下的API,建议:
fluid.program_guard -> paddle.static.program_guard
fluid.Executor -> paddle.static.Executor
fluid.Program() -> paddle.static.Program()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,已经改了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码风格也改好了,请问CI-Static-Check测试是需要管理员处理才能通过嘛


if __name__ == '__main__':
paddle.enable_static()
unittest.main()
8 changes: 4 additions & 4 deletions python/paddle/tensor/logic.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,8 @@ def greater_equal(x, y, name=None):
The output has no gradient.

Args:
x(Tensor): First input to compare which is N-D tensor. The input data type should be bool, float32, float64, int32, int64.
y(Tensor): Second input to compare which is N-D tensor. The input data type should be bool, float32, float64, int32, int64.
x(Tensor): First input to compare which is N-D tensor. The input data type should be bool, float16, float32, float64, int32, int64.
y(Tensor): Second input to compare which is N-D tensor. The input data type should be bool, float16, float32, float64, int32, int64.
name(str, optional): The default value is None. Normally there is no need for
user to set this property. For more information, please refer to :ref:`api_guide_Name`.
Returns:
Expand All @@ -518,13 +518,13 @@ def greater_equal(x, y, name=None):
check_variable_and_dtype(
x,
"x",
["bool", "float32", "float64", "int32", "int64"],
["bool", "float16", "float32", "float64", "int32", "int64"],
"greater_equal",
)
check_variable_and_dtype(
y,
"y",
["bool", "float32", "float64", "int32", "int64"],
["bool", "float16", "float32", "float64", "int32", "int64"],
"greater_equal",
)
helper = LayerHelper("greater_equal", **locals())
Expand Down