Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fp16 dtype checking for paddle.diag API #50848

Merged
merged 8 commits into from
Feb 27, 2023
Merged

fix fp16 dtype checking for paddle.diag API #50848

merged 8 commits into from
Feb 27, 2023

Conversation

mrcangye
Copy link
Contributor

@mrcangye mrcangye commented Feb 23, 2023

PR types

Bug fixes

PR changes

APIs

Describe

paddle.diag API需增加FP16类型检查

#50832

关联中文文档修复链接:PaddlePaddle/docs#5641

@paddle-bot
Copy link

paddle-bot bot commented Feb 23, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

check_variable_and_dtype(x, 'x', ['float32', 'float64'], "log")
check_variable_and_dtype(
x, 'x', ['float16', 'float32', 'float64'], "log"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里修改的是log,上面是diag
不要忘了同步修改中英文文档

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里修改的是log,上面是diag 不要忘了同步修改中英文文档

尴尬了,已改正

Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit ebea088 into PaddlePaddle:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants