[Divide by 0 Error] add lu check #49974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
1
to
37
| # Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import unittest | ||
|
|
||
| import numpy as np | ||
|
|
||
| import paddle | ||
|
|
||
|
|
||
| class TestSparseEmbeddingAPIError(unittest.TestCase): | ||
| def test_errors(self): | ||
| with paddle.fluid.dygraph.guard(): | ||
| # The size of input in sparse_embedding should not be 0. | ||
| def test_0_size(): | ||
| array = np.array([], dtype=np.float32) | ||
| x = paddle.to_tensor( | ||
| np.reshape(array, [0, 0, 0]), dtype='float32' | ||
| ) | ||
| paddle.linalg.lu(x, get_infos=True) | ||
|
|
||
| self.assertRaises(ValueError, test_0_size) | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() |
There was a problem hiding this comment.
这个单测不需要新建文件。放到python/paddle/fluid/tests/unittests/test_lu_op.py即可
python/paddle/tensor/linalg.py
Outdated
Comment on lines
2161
to
2163
| if x.size == 0: | ||
| raise ValueError("input size should not be 0") | ||
|
|
There was a problem hiding this comment.
这个判断放到C++端吧。放到python端会影响到API性能
zhiboniu
approved these changes
Feb 1, 2023
pangengzheng
pushed a commit
to pangengzheng/Paddle
that referenced
this pull request
Feb 2, 2023
* [Divide by 0 Error] add lu check * [Divide by 0 Error] lu check migrate to c++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe