转换规则 No.359 #257
Merged
转换规则 No.359 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
This was referenced Aug 26, 2023
zhwesky2010
reviewed
Aug 28, 2023
paconvert/api_matcher.py
Outdated
| def generate_code(self, kwargs): | ||
| new_kwargs = {} | ||
| if "left" in kwargs: | ||
| left = kwargs.pop("left").strip("(").strip(")") |
There was a problem hiding this comment.
这样实现吧，https://github.com/PaddlePaddle/PaConvert/blob/master/paconvert/api_matcher.py#L1050
因为kwargs.pop("left")可能是一个变量，这样就无法判断了：
left = True
torch.linalg.solve_triangular(left=left)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
PR Docs
#112
359 torch.linalg.solve_triangular
映射文档修改 PaddlePaddle/docs#6141
PR APIs