转换规则No64 torch.nn.functional.max_pool1d #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ROckDog22
reviewed
Jun 25, 2023
paconvert/api_mapping.json
Outdated
| ], | ||
| "unsupport_args": [ | ||
| "dilation", | ||
| "return_indices" |
There was a problem hiding this comment.
这个return_indices应该是支持转化的，paddle和torch返回类型不同，int32和int64，属于风格差异，通过转化类型可以在单测里面进行比较
There was a problem hiding this comment.
很抱歉隔了很久才开始处理这个问题，麻烦帮忙check一下增加的单元测试中的case5和case6，都使用了return index，但是case6的return shape是不同的
Liyulingyue
changed the title
|
请解决下冲突 |
zhwesky2010
reviewed
Jul 24, 2023
| input = torch.tensor([[[ 1.1524, 0.4714, 0.2857, 0.4586, 0.9876, 0.5487], | ||
| [-1.2533, -0.9829, -1.0981, 0.7655, 0.8541, 0.9873], | ||
| [ 0.1507, -1.1431, -2.0361, 0.2344, 0.5675, 0.1546]]]) | ||
| result, index = F.max_pool1d(input , 5, stride=2, padding=2, ceil_mode=True, return_indices=True) |
There was a problem hiding this comment.
return_indices=True 上面不是也有吗，但是没有报错
There was a problem hiding this comment.
很抱歉回复晚了上面这两个的输入矩阵维度不同
|
@Liyulingyue 张师傅，别忘了这个PR哈 |
Liyulingyue
commented
Aug 19, 2023
Liyulingyue
commented
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
根据表格信息，对应文档已存在，未找到对应PR
PR APIs
API Discriptions
#112 case 64