Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 19 Increasing the performance through increasing the number of… #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardebel
Copy link

… separately rendered frames.h

Changed 5 references to r-value references to fix build errors for mingw64-gcc and VS std c++20

… separately rendered frames.h

Changed 5 references to r-value references to fix build errors for mingw64-gcc and VS std c++20
@ButchDean
Copy link

ButchDean commented Jan 19, 2023

A few of questions:

  1. What errors were you getting?
  2. l-value references and r-value references are two very different things. I can't see how changing the function signature is a fix. How do you know there is not a better fix?
  3. If you were getting build errors, how did you verify faster performance from just using l-value references if the code refused to build? This pull request looks like it is for two different reasons that don't quite make sense.
  4. This is not c++20 code. Why are you building with the c++20 standard? The existing standard in CMakeTests.txt clearly states c++11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants