Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #12

Closed
wants to merge 62 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
edee46d
Added version print statements to all tasks.
williamrowell May 20, 2023
74d14fa
CommandShellCheck, SC2046 Quote this to prevent word splitting.
williamrowell May 20, 2023
bc86fa6
update wdl-ci config file after successful tests
github-actions[bot] May 20, 2023
c631102
Fix htsbox version command.
williamrowell May 20, 2023
28d0011
update wdl-ci config file after successful tests
github-actions[bot] May 20, 2023
052365f
update submodule
williamrowell May 24, 2023
fcbd54c
Create LICENSE
williamrowell Jun 2, 2023
de2e218
Set max retries to 3 for HPC backend configuration
hkeward Jun 6, 2023
0ba71f4
Format docs; add backend-specific docs
hkeward Jun 27, 2023
e1b4074
Update paths for AWS reference files
hkeward Jun 27, 2023
c7714fe
Allow user to override container registry
hkeward Jul 4, 2023
5d1299b
Avoid underestimating disk size based on first element of array.
williamrowell Aug 11, 2023
cb9f17f
update wdl-ci config file after successful tests
github-actions[bot] Aug 11, 2023
6ea580a
Merge pull request #7 from PacificBiosciences/bugfix/disk-size-arrays
williamrowell Aug 14, 2023
9c6c96e
Calculate total bases input for each parent to set yak params on the fly
gconcepcion Aug 16, 2023
c9f7092
less than not greater than
gconcepcion Aug 16, 2023
e873f20
Document submitting the workflow directly to Cromwell using cURL
hkeward Aug 23, 2023
902f926
Add dependencies.zip to gitignore
hkeward Aug 23, 2023
f1e76ea
Merge pull request #8 from PacificBiosciences/docs/cromwell-curl-command
hkeward Aug 23, 2023
56833d4
Adding multi-reference alignment option
gconcepcion Sep 22, 2023
a40d2a2
add yak bloom filter condition
gconcepcion Sep 22, 2023
fcf9ffe
fix coverage
gconcepcion Sep 22, 2023
d462924
determine yak settings for both parents rather than independently
gconcepcion Sep 25, 2023
af88a08
fix tests and remove some debug comments I missed
gconcepcion Sep 25, 2023
137d6a9
update wdl-ci config file after successful tests
github-actions[bot] Sep 25, 2023
6c02327
update wdl-ci config file after successful tests
github-actions[bot] Sep 25, 2023
49acf5c
Take a stab at estimating depth based on filesize.
williamrowell Sep 28, 2023
f24e1e6
changed flag name and fixed my flipped logic
williamrowell Sep 28, 2023
42d0d84
Adjusted tests.
williamrowell Sep 28, 2023
c8a9b8d
Memory is an int.
williamrowell Sep 28, 2023
4273515
update wdl-ci config file after successful tests
github-actions[bot] Sep 28, 2023
2dc2760
added warning comment about estimating depth by filesize
williamrowell Sep 28, 2023
ebe6afe
Explicitly pass default `yak count` and `hifiasm` params.
williamrowell Sep 29, 2023
eee833f
Merge pull request #10 from PacificBiosciences/wrowell/yak-suggestions
gconcepcion Oct 2, 2023
05312fe
update README to reflect array of reference inputs as well as arrays …
gconcepcion Oct 26, 2023
de41388
Merge pull request #9 from PacificBiosciences/gconcepcion/yak-changes
gconcepcion Oct 26, 2023
8a84fa6
disclaimer and dockstore.yml
gconcepcion Oct 26, 2023
8cf587a
Merge branch 'develop' into feature/print_versions
gconcepcion Oct 26, 2023
894094f
update wdl-ci config file after successful tests
github-actions[bot] Oct 26, 2023
b9f0bca
clean up README
gconcepcion Oct 26, 2023
8853083
Merge pull request #6 from PacificBiosciences/feature/print_versions
williamrowell Oct 27, 2023
461a6f8
update input jsons
gconcepcion Oct 31, 2023
8a90cd3
add -L3.1g for NGx calculation default for human genomes
gconcepcion Nov 1, 2023
deba05b
substitute paftools for htsbox
gconcepcion Nov 3, 2023
8b9a61d
clean up comments
gconcepcion Nov 3, 2023
150b4a4
now that we are aligning haps separately, there is a single assembly …
gconcepcion Nov 7, 2023
58bdf47
add double quotes and fix tests
gconcepcion Nov 15, 2023
de6bf21
update wdl-ci config file after successful tests
github-actions[bot] Nov 15, 2023
cc5afcb
update wdl-ci json
gconcepcion Nov 15, 2023
fe8b97f
update wdl-common
gconcepcion Nov 15, 2023
b5b121e
update tests for new wdl-common
gconcepcion Nov 15, 2023
f2b175f
fix tests
gconcepcion Nov 15, 2023
2471441
update wdl-ci config file after successful tests
github-actions[bot] Nov 15, 2023
c434e7d
attempt to fix tests
gconcepcion Nov 16, 2023
979ab48
update test locaton and remove tests from non-humanassembly tasks
gconcepcion Nov 16, 2023
22c3fc2
update wdl config to reflect local HPC test running
gconcepcion Nov 17, 2023
421fcc7
temporarily disable tests while troubleshooting
gconcepcion Nov 20, 2023
013c77f
fix tests for CoA
gconcepcion Nov 20, 2023
51a53aa
finally fixed?
gconcepcion Nov 20, 2023
d1b2510
Use latest version of wdl-ci
hkeward Nov 21, 2023
a88f0c2
do not save haplotype bams and output trio merged bam
gconcepcion Nov 21, 2023
37b6ffb
update wdl-ci config file after successful tests
github-actions[bot] Nov 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions .dockstore.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
# The first line refers to the version 1.2 of the .dockstore.yml schema
version: 1.2

# An array of workflows. Each element corresponds to a workflow on Dockstore.
workflows:

# The optional workflow name for a workflow, which may only consist of alphanumerics
# and internal underscores and hyphens, but no spaces or other characters. Names may not exceed 256 characters.
# If using a .dockstore.yml with multiple workflows, this field is required
# to uniquely identify workflows in the repository.
#
# It should be noted that having the name come first is an arbitrary decision.
# You could use subclass instead, for instance. Provided arrays are not broken
# up, the order of fields within a .dockstore.yml is not important.
- name: wdl-humanassembly

# The descriptor language used for the workflow. CWL, WDL, NFL (Nextflow), or GALAXY.
# This cannot be changed once the workflow is registered.
subclass: WDL

# Workflow-wide setting that will affect ALL branches/tags; only set this as needed in a main branch.
# Set to true to publish an unpublished workflow, or false to unpublish a published workflow.
# Omitting the publish setting leaves the publish-state unchanged (recommended for all non-primary branches).
# publish: <Boolean>

# The absolute path to the primary descriptor file in the Git repository.
# - For CWL, the primary descriptor is a .cwl file.
# - For WDL, the primary descriptor is a .wdl file.
# - For Galaxy, the primary descriptor is a .ga file.
# - Nextflow differs from these as the primary descriptor is a nextflow.config file.
primaryDescriptorPath: /workflows/main.wdl

# An optional array of absolute paths to test parameter files in the Git repository.
# For example...
# testParameterFiles:
# - /null-model/null-model.json
# - /null-model/null-model-binary.json
# testParameterFiles: <String Array>

# An optional path to a workflow-specific readme in the Git repository. If not provided, Dockstore will show
# the readme.md present at the root of the Git repository if it is present.
# If you have multiple workflows in a single Git repository, it is recommend to give each one a readme.
readMePath: /README.md

# An optional array of authorship information.
# Note that if orcid is present, then all other fields will be ignored, as information will be taken from orcid.
# If orcid is not present, make sure to at a minimum include the name field for each author.
authors:
- orcid: 0000-0001-5921-2022 # Juniper Lake
- orcid: 0000-0001-7628-5645 # Gregory Concepcion
- orcid: 0000-0002-7422-1194 # William Rowell
- orcid: 0000-0002-5507-0896 # Heather Ward
- orcid: 0009-0001-0205-4614 # Karen Fang

# A boolean that will change the default version to be displayed on Dockstore. Default: False.
# A value of true will automatically display the latest tag updated as default.
# A value of false will retain the default version that has been specified via the Dockstore UI.
latestTagAsDefault: False

# The optional filters section allow specifying sets of Git branches and tags to include for the workflow.
# If no filters are given, all branches and tags are included.
# Branches and tags are arrays of pattern-strings.
# Pattern-strings use Unix-style Glob syntax by default (Ex: `develop`, `myworkflow/**`)
# https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/nio/file/FileSystem.html#getPathMatcher(java.lang.String)
# or RegEx when the string is surrounded by / (Ex: `/develop/`, `/myworkflow\/.*/`).
filters:
branches: [ /develop/ ]
tags: [ /v.*/ ]
2 changes: 1 addition & 1 deletion .github/workflows/lint-test-workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }}
- name: wdl-ci
uses: dnastack/wdl-ci@v0.1.6
uses: dnastack/wdl-ci@v1.0.0
with:
wallet-url: ${{ secrets.WALLET_URL }}
wallet-client-id: ${{ secrets.WALLET_CLIENT_ID }}
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
inputs.test_data*.json
.wdltest*
dependencies.zip
34 changes: 34 additions & 0 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
Copyright (c) 2023, Pacific Biosciences of California, Inc.

All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted (subject to the limitations in the
disclaimer below) provided that the following conditions are met:

* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.

* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following
disclaimer in the documentation and/or other materials provided
with the distribution.

* Neither the name of Pacific Biosciences nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.

NO EXPRESS OR IMPLIED LICENSES TO ANY PARTY'S PATENT RIGHTS ARE
GRANTED BY THIS LICENSE. THIS SOFTWARE IS PROVIDED BY PACIFIC
BIOSCIENCES AND ITS CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED
WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL PACIFIC BIOSCIENCES OR ITS
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
Loading