New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding simple 'locsAndConfs' TCN input vector #41

Merged

Purg merged 13 commits into PTG-Kitware:main from cameron-a-johnson:dev/simple-tcn-input-vector

Nov 6, 2024

Collaborator

cameron-a-johnson commented Nov 4, 2024

What does this PR do?

Fixes #<issue_number>

Before submitting

Did you make sure title is self-explanatory and the description concisely explains the PR?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you list all the breaking changes introduced by this pull request?
Did you test your PR locally with pytest command?
Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃


          Adding simple 'locsAndConfs' TCN input vector

8eeb729

cameron-a-johnson marked this pull request as draft

November 5, 2024 16:29

Purg reviewed

View reviewed changes

configs/experiment/m2/feat_locsConfs.yaml Outdated Show resolved Hide resolved


          remove custom arg

706d6f0

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/_data.py Outdated Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Outdated Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Outdated Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Outdated Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Outdated Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Outdated Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Outdated Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Show resolved Hide resolved

Purg reviewed

View reviewed changes

tcn_hpl/data/vectorize/locs_and_confs.py Outdated Show resolved Hide resolved

cameron-a-johnson and others added 11 commits

November 5, 2024 16:16


          Update tcn_hpl/data/vectorize/_data.py

80c5bc8

Co-authored-by: Paul Tunison <[email protected]>


          remove unnecessary import

3b7f2cb


          Merge branch 'dev/simple-tcn-input-vector' of github.com:cameron-a-jo…

d6a2d5c

…hnson/TCN_HPL into dev/simple-tcn-input-vector


          Adding arguments documentation for LocsAndConfs

65675a6


          Update tcn_hpl/data/vectorize/locs_and_confs.py

4d80561

Co-authored-by: Paul Tunison <[email protected]>


          Update tcn_hpl/data/vectorize/locs_and_confs.py

9554fd0

Co-authored-by: Paul Tunison <[email protected]>


          Update tcn_hpl/data/vectorize/locs_and_confs.py

31d1a15

Co-authored-by: Paul Tunison <[email protected]>


          set vector type at construction. Remove ravel.

add6dad


          Merge branch 'dev/simple-tcn-input-vector' of github.com:cameron-a-jo…

d2ce9b4

…hnson/TCN_HPL into dev/simple-tcn-input-vector


          compute the vector length instead of hard-coding it.

e137021


          add todo's for PR things I'm not getting to yet.

202f9aa

Purg approved these changes

View reviewed changes

Purg marked this pull request as ready for review

November 6, 2024 21:10

Purg merged commit 79cf1d1 into PTG-Kitware:main

0 of 11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet