Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sample_02_Serialized to composer samples #834

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

kw-pr
Copy link
Contributor

@kw-pr kw-pr commented Dec 12, 2024

The sample is missing but it works.

There are also 3 Sample_12 files missing. But they do not work mainly because PhpPptTree does not exists.

Description

If this is missing on purpose, just close this.

Fixes no issue.

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

None of the above, sorry.

It was missing but it works.

There are also 3 Sample_12 files missing. But they do not work mainly because PhpPptTree does not exists.
@Progi1984
Copy link
Member

@kw-pr Could you rebase your PR, please ?

@Progi1984 Progi1984 merged commit c412543 into PHPOffice:master Dec 12, 2024
28 checks passed
@Progi1984 Progi1984 added this to the 1.2.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants