Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type is num unless one of the values is non-numeric #797

Conversation

LilyEssence
Copy link
Contributor

What:

  • only set datatype to 'str' if one of the values is non-numeric

Why:

  • if the first value is numeric, but the later values are not, for example ['1', 'FOO'], the entry will be set to numlit, but since the second entry is not a numeric, the ppt fails to open and requires repair.
  • The value should be set to 'strlit' if any of the values are non-numeric.

@auto-assign auto-assign bot requested a review from Progi1984 March 27, 2024 01:09
@Progi1984
Copy link
Member

Fixed in #778 by @ksmeeks0001

@Progi1984 Progi1984 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants