Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various sniffs: always return EOF pointer #95

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 11, 2023

Description

Recreation of upstream PR squizlabs/PHP_CodeSniffer#3911:

Always return EOF pointer for files scanning the complete file in one go as if any of the error conditions are hit, it is useless to try again for the same file.

Suggested changelog entry

N/A

... for files scanning the complete file in one go as if any of the error conditions are hit, it is useless to try again for the same file.
@jrfnl jrfnl force-pushed the feature/various-return-eof-ptr branch from 07a6c35 to 84ff93d Compare December 4, 2023 23:48
@jrfnl jrfnl merged commit af7f3c2 into master Dec 4, 2023
63 checks passed
@jrfnl jrfnl deleted the feature/various-return-eof-ptr branch December 4, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant