AbstractPatternSniff: prevent PHP notice #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredden
approved these changes
Jul 29, 2024
.... to allow for adding additional test case files.
In a live coding situation, the token triggering the pattern being looked for could be at or near the end of the file. This could lead to a situation where the pattern could never match anyhow as there are not enough tokens left in the file to match against. In this situation, the sniff could trigger the following PHP error: ``` Increment on type bool has no effect, this will change in the next major version of PHP in path/to/phpcs/src/Sniffs/AbstractPatternSniff.php on line 627 ``` This commit prevents this error by bowing out early if there are not enough tokens in the file under scan to match the pattern. Tested via the `Squiz.Functions.FunctionDeclaration` sniff via which this issue was discovered.
jrfnl
force-pushed
the
feature/abstractpatternsniff-fix-bug
branch
from
e536947 to
49b8494
Compare
|
Rebased without changes. Merging once the build has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Squiz/FunctionDeclaration: rename test case file
.... to allow for adding additional test case files.
AbstractPatternSniff: prevent PHP notice
In a live coding situation, the token triggering the pattern being looked for could be at or near the end of the file.
This could lead to a situation where the pattern could never match anyhow as there are not enough tokens left in the file to match against.
In this situation, the sniff could trigger the following PHP error:
This commit prevents this error by bowing out early if there are not enough tokens in the file under scan to match the pattern.
Tested via the
Squiz.Functions.FunctionDeclarationsniff via which this issue was discovered.Suggested changelog entry
AbstractPatternSniff: bug fix for potential PHP notice during live coding
Related issues/external references
Loosely related to #152 as this issue was discovered when creating an update for the fixer conflict list.
Types of changes