Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEAR/FunctionCallSignature: minor tweaks #134

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Dec 5, 2023

Description

Recreation of upstream PR squizlabs/PHP_CodeSniffer#3667:

Minor defensive coding and documentation improvements + an additional unit test.

The original PR was bigger and contained a bug fix, but was fixed in parallel via another commit.

Fixed by commit squizlabs/PHP_CodeSniffer@9445108 in response to issue squizlabs/PHP_CodeSniffer#3666, though this PR still contains some minimal differences (defensive coding, comment + minor difference in the fix) which may be worth having a look at.

Suggested changelog entry

N/A

Minor defensive coding and documentation improvements + an additional unit test.
@jrfnl jrfnl added this to the 3.8.0 milestone Dec 5, 2023
@jrfnl jrfnl merged commit 3c80ec8 into master Dec 5, 2023
65 checks passed
@jrfnl jrfnl deleted the feature/pear-functioncallsignature-minor-tweaks branch December 5, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant