Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PDB links #52

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Update PDB links #52

wants to merge 2 commits into from

Conversation

odcambc
Copy link

@odcambc odcambc commented Dec 25, 2023

Updates two old links to correct ones.

mhekkel
mhekkel reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@mhekkel mhekkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the URL in compound.cpp is a good idea, I obviously forgot that one. (The URL was already corrected in the update script). However, changing the URL in a dictionary file that is simply a copy from elsewhere is not such a good idea.

@mhekkel mhekkel self-requested a review December 27, 2023 08:53
@odcambc
Copy link
Author

odcambc commented Dec 27, 2023

Thanks for catching that - careless searching by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhekkel mhekkel Awaiting requested review from mhekkel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odcambc @mhekkel