-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save images #1
base: main
Are you sure you want to change the base?
Save images #1
Conversation
tinhnguyen-starglobal
commented
May 25, 2022
- photos in png format
- output at 2X resolution
… change output format to png
LGTM! |
Hi @fritz-ebner please help me review this PR. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is correct, but you will have to check with Dmytro.
I think the code is line 48, should not do sigmoid(tc)
Hi @fritz-ebner as you can see, To avoid getting you confused I will remove this line of code. Please help me check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think line 57 still has to be
let confidenceInClass = tc * bestClassScore
Hi @fritz-ebner |