Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save images #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

tinhnguyen-starglobal
Copy link

  • photos in png format
  • output at 2X resolution

@tinhnguyen-starglobal
Copy link
Author

LGTM!

@tinhnguyen-starglobal
Copy link
Author

Hi @fritz-ebner please help me review this PR. Thanks

Copy link

@graySquirrel graySquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is correct, but you will have to check with Dmytro.
I think the code is line 48, should not do sigmoid(tc)

@tinhnguyen-starglobal
Copy link
Author

Hi @fritz-ebner as you can see,
let confidence = sigmoid(tc)
-> we create a constant "confidence" here and assigned sigmoid(tc) to it.
But I found that is reason, that led to a low confidence score. So I ignored the "confidence" value and didn't use it anymore.

To avoid getting you confused I will remove this line of code. Please help me check.

Copy link

@fritz-ebner fritz-ebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 57 still has to be
let confidenceInClass = tc * bestClassScore

@tinhnguyen-starglobal
Copy link
Author

Hi @fritz-ebner
In the beginning, I intend to use: let confidenceInClass = tc * bestClassScore
But Alexey and Dmytro Doroshenko explained we should use: let confidenceInClass = tc
Because: tc values in range [0,1] and they are bounding box score, while bestClassScore is a probability of a specific class on this (current) bounding box.
If you need more detail please let me know. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants