Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUNDI-3795: Improve authentication config #5

Merged
merged 22 commits into from
Dec 24, 2024
Merged

GUNDI-3795: Improve authentication config #5

merged 22 commits into from
Dec 24, 2024

Conversation

marianobrc
Copy link

@marianobrc marianobrc commented Dec 23, 2024 •
edited
Loading

What does this PR do?

  • Syncs with the template repo
  • Updates the er-client to fix issue testing credentials
  • Improves error handling on ER API errors
  • Improves config forms using UI schema and conditionals. The form will either show token or username & password depending on the selected authentication type.
  • Extends test coverage for the auth action

Token:

er_auth_token

Username & Password:

er_auth_up

Relevant link(s)

GUNDI-3795

chrisdoehring and others added 20 commits November 18, 2024 17:22
@chrisdoehring
Add ExcecutableMixin.
278020c
@chrisdoehring
Merge pull request PADAS#33 from PADAS/add-executable-mixin
ce36740 
Add ExcecutableMixin.
@chrisdoehring
Update README.md
ede3938
@vgarcia13
Initial Release
e87a5f5
@vgarcia13
Merge pull request PADAS#36 from PADAS/initial-release
b896207 
Initial release
@vgarcia13
Revert "Initial release"
575124a
@chrisdoehring
Merge pull request PADAS#37 from PADAS/revert-36-initial-release
539b4cc 
Revert "Initial release"
@marianobrc
Support setting action schedules by command or decorator
4db0c9b
@marianobrc
Make timezone optional
92e57a5
@marianobrc
Fix regular expressions for crontab
cb7aa86
@marianobrc
Add test coverage for regitration with custom action schedule
a7794cb
@marianobrc
Add instructions about custom schedule usage in the readme
5e0bf20
@marianobrc
Merge pull request PADAS#39 from PADAS/gundi-3819-action-schedules
14b1314 
GUNDI-3819: Support custom action schedules
@marianobrc
Fix wrong mocks that may affect tests
87677f6
@marianobrc
Merge pull request PADAS#40 from PADAS/fix-mock-responses
446db36 
Fix wrong mocks that may affect tests
@marianobrc
Sync with the template repo
5bc7734
@marianobrc
Improve error handling in test auth
f8afb45
@marianobrc
[WIP] Improve config form for authentication using jsonschema conditi…
2ce9f21 
…onals
@marianobrc
Update the er-client
ce1dbb2
@marianobrc
Improve auth config to show either token or usr n psw fields
6d136ff
davidovichmarcos
davidovichmarcos approved these changes Dec 24, 2024
View reviewed changes
Copy link

@davidovichmarcos davidovichmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marianobrc marianobrc marked this pull request as ready for review December 24, 2024 15:02
@marianobrc marianobrc merged commit 34004fd into main Dec 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidovichmarcos davidovichmarcos davidovichmarcos approved these changes

@chrisdoehring chrisdoehring chrisdoehring approved these changes

@vgarcia13 vgarcia13 Awaiting requested review from vgarcia13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marianobrc @chrisdoehring @davidovichmarcos @vgarcia13