Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a page link with information about discord #46

Closed
wants to merge 8 commits into from
Closed

Created a page link with information about discord #46

wants to merge 8 commits into from

Conversation

VaithiSniper
Copy link

For Issue: #14

Fixes:

Additions:

  • Added discord page
  • Added nav-item in index.html to discord.html

Checklist

  • Ensured there is an open issue for your PR
  • Ensured you are the contributer assigned to the Issue for this PR
  • Added comments to additions
  • Followed common formatting conventions for the contribution language
  • Tested code to ensure original features are working

Screenshots

1
2

@VaithiSniper
Copy link
Author

hey can you review this @S3cBar0n

@thatrobotdev thatrobotdev self-requested a review October 21, 2021 07:21
Copy link
Contributor

@thatrobotdev thatrobotdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great start so far! Sorry for taking a long time to get back to you, school got pretty busy!

It looks like the new page that you added doesn't match the current style of the homepage, could you re-use bits in the stylesheet instead of modeling it after the old google site?

Also, great job adding it to the navbar! I think we have a new navbar design since you last worked on the website, so could you update that styling as well?

Thank you! :D

@thatrobotdev thatrobotdev linked an issue Oct 21, 2021 that may be closed by this pull request
@thatrobotdev thatrobotdev added enhancement New feature or request and removed Status: Needs Review labels Oct 21, 2021
@VaithiSniper
Copy link
Author

can you check now?

@VaithiSniper
Copy link
Author

is this PR still active?

@VaithiSniper
Copy link
Author

@S3cBar0n @thatrobotdev

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a page link with information about our discord
3 participants