Skip to content

Commit

Permalink
increment version
Browse files Browse the repository at this point in the history
  • Loading branch information
hxtree committed Oct 8, 2021
1 parent d62e09c commit 03bfcae
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ All releases must adhere to [SemVer 2](https://semver.org/) naming convention an
## PHPMarkup [Unreleased]
Released: TBA. Notable changes:

## PHPMarkup 4.2.5
Released: 2021-10-08. Notable changes:
* Fixed: QA tests.

## PHPMarkup 4.2.4
Released: 2021-10-08. Notable changes:
* Added: InnerXML sanitization.
Expand Down
15 changes: 7 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,25 @@ First off, thanks for taking the time to contribute!

For local package development use [Docker](https://www.docker.com/products/docker-desktop):

Build Test container
**Step 1**) Pull code and build Test container
```
git clone https://github.com/Ouxsoft/phpmarkup.git
cd phpmarkup
docker build --target test --tag phpmarkup:latest -f Dockerfile .
docker run -it --mount type=bind,source="$(pwd)"/,target=/application/ phpmarkup:latest composer install
```

Run Automated Unit Tests using local volume
```
docker run -it --mount type=bind,source="$(pwd)"/,target=/application/ phpmarkup:latest composer test
```
**Step 2**) Make code changes.

Run Automated Benchmark Tests using local volume
**Step 3**) Run Automated QA using local volume
```
docker run -it --mount type=bind,source="$(pwd)"/,target=/application/ phpmarkup:latest ./vendor/bin/phpbench run tests/src/Benchmark --report=default
docker run -it --mount type=bind,source="$(pwd)"/,target=/application/ phpmarkup:latest composer qa
```

Rebuild Docs
**Step 4**) Rebuild Docs
```
docker build --target docs --tag phpmarkup:docs-latest -f Dockerfile .
docker run -it --mount type=bind,source="$(pwd)"/,target=/app/ phpmarkup:docs-latest bash -c "cd /app/docs && doxygen Doxyfile && doxyphp2sphinx Ouxsoft::PHPMarkup"
```

**Step 5**) Submit PR
2 changes: 1 addition & 1 deletion src/Engine.php
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ public function sanitizeXml(string $xml): string
// strip args
$xml = preg_replace("/<arg.*?>(.*)?<\/arg>/im", '', $xml);
// strip INDEX_ATTRIBUTE
$xml = $this->stripAttribute($xml, [self::INDEX_ATTRIBUTE]);
$xml = $this->stripAttributes($xml, [self::INDEX_ATTRIBUTE]);

return $xml;
}
Expand Down

0 comments on commit 03bfcae

Please sign in to comment.