647 Refactor pull-up sheets to use dynamic height #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored to work with SwiftUI views presented as sheets, and SwiftUI views wrapped in view controllers and presented via navigation controllers
…w dynamic sheets - Reverted some of the views to `PresentHostingController` because using scroll views, not compatible with dynamic heights due to the lack of intrinsic size
jeden
changed the title
zhouxl
approved these changes
Dec 19, 2024
|
Have you tried the effect? |
Which effect are you referring to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#647
Summary of Changes
Refactored the implementation of the half-sheet so that its height was dynamically set depending on the content.
This solution doesn't work with views having scroll views (even when combined with a geometry reader) because of the intrinsic size. These views will use the existing
PresentHostingControllerwith a fixed-sized sheet that can expand from half to full height.Need Regression Testing
All views (listed below) should be checked to verify the correct layout.
Risk Assessment
Additional Notes
Views migrated to use the dynamic pull-up sheet (in
RouteMapunless otherwise specified):MoveAssetsViewinBrowserViewControllerSyncAddDeviceViewBuyProvderViewStakeAmountView.StakeSetupViewJailbreakAlertViewMoveAssetsViewMoveTokenViewNFTTransferViewChildAccountLinkViewNetworkSwitchPopViewViews automatically using the dynamic pull-up sheet (without any refactoring on a per-view basis):
AccountKeysViewshowingAccountKeyRevokeViewAddTokenViewshowingAddTokenConfirmViewBackupListViewshowingDangerousTipSheetViewChildAccountDetailViewshowingUnlinkConfirmViewDevicesInfoViewshowingDangerousTipSheetViewMultiBackupDetailViewshowingDangerousTipSheetViewNFTAddCollectionViewshowingNFTAddCollectionView.NFTCollectionEnableViewNFTDetailPageshowingMoveSingleNFTViewStakeAmountViewshowingStakeConfirmViewSwapViewshowingSwapConfirmViewTokenDetailViewshowingMoveTokenViewWalletHomeViewshowingBackupTipsViewWalletSendAmountViewshowingSendConfirmViewViews using the old
PresentHostingController(inRouteMap):ImportAccountsViewMoveNFTsViewMoveAccountsViewAddTokenSheetViewAccountSwitchViewBrowserAuthnViewBrowserAuthzViewBrowserSignMessageViewBrowserSignTypedMessageViewScreenshots (if applicable)
N/A