564 Insufficient Balance Alert #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lmcmz
requested changes
Dec 19, 2024
| @@ -956,6 +956,12 @@ extension WalletManager { | |||
| return accountInfo.storageCapacity - accountInfo.storageUsed < Self.mininumStorageThreshold | |||
| } | |||
|
|
|||
| var isBalanceInsufficient: Bool { | |||
| guard self.isSelectedFlowAccount else { return false } | |||
There was a problem hiding this comment.
It will be an issue, when the flag is checked but the accountInfo is not fetched yet.
So it will always return false
There was a problem hiding this comment.
That actually happens, but WalletNewsHandler is subscribed to the accountDataDidUpdate event, and when an update occurs (i.e. when the account has been fetched) the logic is re-evaluated.
That means that even though the notification doesn't appear immediately, it will after a few seconds.
lmcmz
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Summary of Changes
Implemented as per specs
Need Regression Testing
Risk Assessment
Additional Notes
Note: this requirement:
is implemented, but not currently working, because we must implement deeplinks in the app. Tapping the notification will open the browser window, but it will show a blank page.
Deeplinks will be implemented in #672
Screenshots (if applicable)