Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add feature toggle for storage alert feature #631

Closed
Peppermint1020 opened this issue Dec 5, 2024 · 3 comments · Fixed by #639
Closed

[FEATURE] Add feature toggle for storage alert feature #631

Peppermint1020 opened this issue Dec 5, 2024 · 3 comments · Fixed by #639
Assignees
@jeden

Comments

@Peppermint1020
Copy link
Collaborator

Peppermint1020 commented Dec 5, 2024 •
edited by jeden
Loading

Relates to:
@Peppermint1020 Peppermint1020 converted this from a draft issue Dec 5, 2024
@jeden jeden moved this from Todo to In Progress in Flow Wallet Dec 5, 2024
@jeden jeden moved this from In Progress to Code Review in Flow Wallet Dec 5, 2024
@jeden jeden added blocked and removed blocked labels Dec 5, 2024
jeden added a commit that referenced this issue Dec 5, 2024
@jeden
631 Add feature toggle for storage alert feature
81bbec6 
#631
@jeden jeden mentioned this issue Dec 5, 2024
Merged
5 tasks
jeden added a commit that referenced this issue Dec 6, 2024
@jeden
631 Add feature toggle for storage alert feature (#637)
36fa19a 
#631
@jeden jeden moved this from Code Review to Ready for QA in Flow Wallet Dec 6, 2024
@jeden
Copy link
Contributor

jeden commented Dec 6, 2024

@Peppermint1020 ready for review, build https://testflight.apple.com/v1/app/6478996758?build=156653565.

@jeden jeden moved this from Ready for QA to Code Review in Flow Wallet Dec 6, 2024
jeden added a commit that referenced this issue Dec 6, 2024
@jeden
631 Add feature toggle for storage alert feature
d780253 
#631

Set the default value to false if the config property is not provided
@jeden jeden mentioned this issue Dec 6, 2024
Merged
5 tasks
@jeden jeden linked a pull request Dec 6, 2024 that will close this issue
631 Add feature toggle for storage alert feature #639
Merged
5 tasks
jeden added a commit that referenced this issue Dec 6, 2024
@jeden
631 Add feature toggle for storage alert feature (#639)
5da21fd 
#631

Set the default value to false if the config property is not provided
@jeden jeden closed this as completed in #639 Dec 6, 2024
@jeden jeden moved this from Code Review to Ready for QA in Flow Wallet Dec 6, 2024
@jeden
Copy link
Contributor

jeden commented Dec 6, 2024

@Peppermint1020 updated build https://testflight.apple.com/v1/app/6478996758?build=156663130

@Peppermint1020
Copy link
Collaborator Author

@lmcmz Could you check this feature? I am not sure how could I test this one

@Peppermint1020 Peppermint1020 moved this from Ready for QA to Done in Flow Wallet Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeden jeden

Labels
None yet
Projects
Flow Wallet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

631 Add feature toggle for storage alert feature Outblock/FRW-iOS
2 participants
@jeden @Peppermint1020