631 Add feature toggle for storage alert feature (#639)

#631 Set the default value to false if the config property is not provided
Outblock · Dec 6, 2024 · 5da21fd · 5da21fd
1 parent 36fa19a
commit 5da21fd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/FRW/Services/Manager/Config/RemoteConfig.swift b/FRW/Services/Manager/Config/RemoteConfig.swift
@@ -209,7 +209,7 @@ extension RemoteConfigManager {
                 return true
             case .insufficientStorage:
                 // TODO: [AB] Not very elegant adding a dependency here, but implementing in a different way would probably require major refactoring
-                return WalletManager.shared.isStorageInsufficient && RemoteConfigManager.shared.config?.features.insufficientStorage ?? true
+                return WalletManager.shared.isStorageInsufficient && RemoteConfigManager.shared.config?.features.insufficientStorage ?? false
             default:
                 return false
             }

diff --git a/FRW/Services/Manager/TransactionManager.swift b/FRW/Services/Manager/TransactionManager.swift
@@ -266,7 +266,7 @@ extension TransactionManager {
 
                             switch result.errorCode {
                             case .storageCapacityExceeded:
-                                if RemoteConfigManager.shared.config?.features.insufficientStorage ?? true {
+                                if RemoteConfigManager.shared.config?.features.insufficientStorage ?? false {
                                     AlertViewController.showInsufficientStorageError(minimumBalance: WalletManager.shared.minimumStorageBalance.doubleValue)
                                 }
                             default:

diff --git a/FRW/UI/Component/InsufficientStorageToastView.swift b/FRW/UI/Component/InsufficientStorageToastView.swift
@@ -23,7 +23,7 @@ protocol InsufficientStorageToastViewModel: ObservableObject {
 }
 
 extension InsufficientStorageToastViewModel {
-    private var isInsufficientStorageEnabled: Bool { RemoteConfigManager.shared.config?.features.insufficientStorage ?? true }
+    private var isInsufficientStorageEnabled: Bool { RemoteConfigManager.shared.config?.features.insufficientStorage ?? false }
 
     var showInsufficientFundsToast: Bool {
         self.isInsufficientStorageEnabled && self.variant != nil