[HOTFIX] Add missing storage warning messages and enhance error handling #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new message entries for "Insufficient Storage" and "Almost run out of account storage" in English, Japanese, Russian, and Chinese locales. - Updated the `WarningStorageLowSnackbar` component to use the new "Almost run out of account storage" message. - Enhanced error handling in the `NewsService` class to prevent the news list from being emptied due to evaluation errors. Closes #316
tombeckenham
temporarily deployed
to
production
GitHub Actions
Inactive
|
Actually we should simply merge dev to master... it hasn't been released yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging branch to MASTER
Related Issue
Closes #316
Summary of Changes
WarningStorageLowSnackbarcomponent to use the new "Almost run out of account storage" message.NewsServiceclass to prevent the news list from being emptied due to evaluation errors.Need Regression Testing
News items and storage alert should be tested again.
Risk Assessment
Nothing dangerous in this