Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: convert hex to readable value #309

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fixed: convert hex to readable value #309

merged 3 commits into from
Dec 19, 2024

Conversation

zzggo
Copy link
Member

@zzggo zzggo commented Dec 18, 2024

Related Issue

Summary of Changes

update the amount display in transaction popup

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

Copy link
Collaborator

@tombeckenham tombeckenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a really nice PR to start getting into the practice of adding a unit test. Could you please add a unit test in the tests folder for this function? Please let me know if you need help. It should only take a couple of minutes.

@zzggo zzggo merged commit 9902223 into dev Dec 19, 2024
2 checks passed
@zzggo zzggo deleted the decode-signtype-amount branch December 19, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants