Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

298-feature-move-trustconnect-to-background #307

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

tombeckenham
Copy link
Collaborator

Related Issue

Closes #298

Summary of Changes

  • Split up passkey so that the public private key stuff is seperate to the webauthn stuff
  • Moved all that to the background
  • Moved all of that module code to typescript
  • Added 3 methods to wallet that are called from the UI
  • Finally updated the import components to use those new methods rather than importing the passkey code directly
  • Updated webpack config to import the trustconnect wasm file only in the background

Need Regression Testing

Needs all of the import code tests

  • Yes
  • No

Risk Assessment

Affects how wallets are imported

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@tombeckenham tombeckenham requested review from zzggo and lmcmz December 18, 2024 06:01
@tombeckenham tombeckenham marked this pull request as ready for review December 18, 2024 06:01
@tombeckenham tombeckenham linked an issue Dec 18, 2024 that may be closed by this pull request
@tombeckenham tombeckenham merged commit 6b9f0a3 into dev Dec 19, 2024
3 checks passed
@tombeckenham tombeckenham deleted the 298-feature-move-trustconnect-to-background branch December 19, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Move trustconnect to background
2 participants