-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce e2e testing #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Playwright test dependencies to package.json and pnpm-lock.yaml. - Updated .gitignore to exclude test results and Playwright reports. Closes #243
tombeckenham
had a problem deploying
to
production
December 11, 2024 02:37 — with
GitHub Actions
Failure
- Updated ESLint configuration to include e2e tests. - Changed Playwright test directory from './tests' to './e2e'. - Adjusted TypeScript configuration to include e2e files. - Removed obsolete test files: example.spec.ts and wallet.spec.ts. Closes #243
tombeckenham
had a problem deploying
to
production
December 11, 2024 02:39 — with
GitHub Actions
Failure
Closes #243
tombeckenham
temporarily deployed
to
production
December 11, 2024 02:50 — with
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
production
December 11, 2024 04:22 — with
GitHub Actions
Inactive
lmcmz
approved these changes
Dec 16, 2024
Fixes #243
tombeckenham
temporarily deployed
to
production
December 16, 2024 02:32 — with
GitHub Actions
Inactive
tombeckenham
temporarily deployed
to
production
December 16, 2024 02:35 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #243
Summary of Changes
Added Playwright that can be run by developers
Created one test that loads the extension and ensures welcome page is shown
Does not run tests on CI
Need Regression Testing
No code changes that affect the build
Risk Assessment
Additional Notes
More will follow later but will need bigger changes such as adding the emulator