-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
266-feature-update-gas-estimate-in-storage-check #267
266-feature-update-gas-estimate-in-storage-check #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The component got commented out last update, I think you have to add that back in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The component got commented out last update, I think you have to add that back in.
Thanks.
7b1a13a
to
5b3ac07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct now. It's hard to be sure. It's so hard to test. It'll need to go through QA.
…ll as storage Closes #266
Related Issue
Closes #266
Summary of Changes
Changed gas algorithm
From
let averageTxFee = 0.001
to
let averageTxFee = freeGasEnable ? 0 : 0.0005
Need Regression Testing
Changes free gas algo
Risk Assessment