Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

266-feature-update-gas-estimate-in-storage-check #267

Merged
merged 11 commits into from
Dec 16, 2024

Conversation

tombeckenham
Copy link
Collaborator

Related Issue

Closes #266

Summary of Changes

Changed gas algorithm

From
let averageTxFee = 0.001
to
let averageTxFee = freeGasEnable ? 0 : 0.0005

Need Regression Testing

Changes free gas algo

  • [X ] Yes
  • No

Risk Assessment

  • [ X] Low
  • Medium
  • High

Copy link
Member

@zzggo zzggo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component got commented out last update, I think you have to add that back in.

Copy link
Collaborator Author

@tombeckenham tombeckenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component got commented out last update, I think you have to add that back in.

Thanks.

@tombeckenham tombeckenham force-pushed the 266-feature-update-gas-estimate-in-storage-check branch from 7b1a13a to 5b3ac07 Compare December 9, 2024 04:51
Copy link
Collaborator Author

@tombeckenham tombeckenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct now. It's hard to be sure. It's so hard to test. It'll need to go through QA.

@tombeckenham tombeckenham requested a review from zzggo December 9, 2024 05:30
@tombeckenham tombeckenham merged commit 7765bc1 into dev Dec 16, 2024
2 checks passed
@tombeckenham tombeckenham deleted the 266-feature-update-gas-estimate-in-storage-check branch December 16, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants