Skip to content

Commit

Permalink
ROU-11456: Small improvements in pipelines (#441)
Browse files Browse the repository at this point in the history
This PR is for adding small improvements on the github actions.

### What was happening
- The way the github actions were accessing to the secrets and passing
as input parameter to other actions;
- The version of the external github action `actions/checkout`

### What was done
- Now, github actions that require secrets access to them directly
- `actions/checkout` was standardized to v4
- Tested changes in the sandbox

### Checklist
-   [x] tested locally
-   [ ] documented the code
-   [ ] clean all warnings and errors of eslint
- [ ] requires changes in OutSystems (if so, provide a module with
changes)
- [ ] requires new sample page in OutSystems (if so, provide a module
with changes)
  • Loading branch information
rugoncalves authored Dec 20, 2024
2 parents ef36d9c + 3615e4c commit e458b9e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 26 deletions.
13 changes: 2 additions & 11 deletions .github/os-git-actions/setup-gpg/action.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,13 @@
name: 'setup-gpg'
description: 'Prepare to get following commits signed'
inputs:
gpgPriv:
description: 'GPG Private key'
required: true
default: ''
gpgPassPhrase:
description: 'GPG passphrase'
required: false
default: '""'

runs:
using: composite
steps:
- name: Import and load GPG key
uses: crazy-max/ghaction-import-gpg@v6
with:
gpg_private_key: ${{ inputs.gpgPriv }}
passphrase: ${{ inputs.gpgPassPhrase }}
gpg_private_key: ${{ secrets.GPG_SIGN_KEY }}
passphrase: ${{ secrets.GPG_PASSPHRASE }}
git_user_signingkey: true
git_commit_gpgsign: true
11 changes: 0 additions & 11 deletions .github/os-git-actions/signed-commit/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,12 @@ inputs:
description: 'Defines if a `git add.` should be made or not.'
required: false
default: false
gpgPriv:
description: 'GPG Private key'
required: true
default: ''
gpgPassPhrase:
description: 'GPG passphrase'
required: false
default: '""'

runs:
using: composite
steps:
- name: Setup GPG to sign commits
uses: ./.github/os-git-actions/setup-gpg/
with:
gpgPriv: ${{ inputs.gpgPriv }}
gpgPassPhrase: ${{ inputs.gpgPassPhrase }}

- name: Perform git commit
uses: ./.github/os-git-actions/manual-commit/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/DevPR.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
working-directory: ./
steps:
- name: Checkout branch dev
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install project dependencies
run: npm install
Expand All @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout branch dev
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install project dependencies
run: npm install
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/PreRelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,3 @@ jobs:
branch: dev
message: 'Updated into v${{ inputs.new-dev-release }} [skip ci]'
newFiles: true
gpgPriv: ${{ secrets.GPG_SIGN_KEY }}
gpgPassPhrase: ${{ secrets.GPG_PASSPHRASE }}

0 comments on commit e458b9e

Please sign in to comment.