-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read-only change view #110
base: master
Are you sure you want to change the base?
Conversation
@OskarPersson i'm testing it, and still having the same output. EDIT: I set up a Breakpoint at line 100 of admin.py, and found out that wrap_nested_inline_formsets() is not beign called |
Okay. Feel free to add a PR to the |
I just had some time and took another look. As you can see in the result, your code worked (the nested-inline is read only), but the parent container still editable. EDIT Adding "has_change_permission" keyword argument to InlineAdminFormSet will make the Inline Formset ReadOnly as expected. I'm still having a problem, As you can see in the next picture, the + buttons are shown. Clicking them will pop new read-only empty entries. EDIT @OskarPersson i tried to push my changes to this branch (also to a new one) and looks like i don't have permissions to do it. I get 403 Forbidden Error |
@gascarcella You need to make a fork of this repository and push to a branch there. From there you can create a PR to merge your branch into |
Fixes #109