TESTBOX-408 Allow toHaveKey to support struct like objects #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmajano
reviewed
Dec 11, 2024
| @@ -1454,16 +1454,13 @@ component { | |||
| * @throws InvalidTargetType - If we can normalize it to a struct | |||
| */ | |||
| private function normalizeToStruct( any target ){ | |||
| if ( isStruct( arguments.target ) ) { | |||
| return arguments.target; | |||
| } | |||
| if ( isQuery( arguments.target ) ) { | |||
There was a problem hiding this comment.
I see your request, but then this introduces exceptions to be thrown in other locations when the normalization can't happen for things like NON structs.
There was a problem hiding this comment.
which was the previous behaviour?
plus those exceptions are more informative and actionable?
https://trycf.com/gist/5e3f5ecfe2d926faa28be26eed532bb1/acf2023?theme=monokai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ortussolutions.atlassian.net/browse/TESTBOX-408