Blockchain events improvements #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsculac
commented
Nov 29, 2024
zsculac
commented
- Add isBlocking to db
- Move ABI to constants
- Move contract initialization inside ot-ethers
…ain-events-improvements
zsculac
requested review from
branarakic,
u-hubar and
Mihajlo-Pavlovic
as code owners
| @@ -83,6 +96,13 @@ class OtEthers extends BlockchainEventsService { | |||
| `RPC Fallback Provider initialization failed. Fallback Provider quorum: ${FALLBACK_PROVIDER_QUORUM}. Error: ${e.message}.`, | |||
| ); | |||
| } | |||
|
|
|||
| this.operationalWallets[blockchain] = this.getValidOperationalWallets(blockchain); | |||
There was a problem hiding this comment.
I dont think this is needed for event listner as we are not sending any transactions
src/commands/command-executor.js
Outdated
| @@ -449,6 +472,12 @@ class CommandExecutor { | |||
|
|
|||
| const commands = []; | |||
| for (const command of pendingCommands) { | |||
| if (command?.isBlocking === true && command?.parentId === null) { | |||
There was a problem hiding this comment.
You don't need to check if boolean is equal to true, you can just use isBlocking && ...
There was a problem hiding this comment.
Imo we should have stricter conditions, truthy conditions may cause issues that are hard to debug
…d installer, added blockchain events service config validation
…vent-listener Blockchain event listener improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.