Feature/remove get init #3445
Merged
Feature/remove get init #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/remove-get-init
Mihajlo-Pavlovic
requested review from
branarakic and
u-hubar
as code owners
brkagithub
reviewed
Nov 29, 2024
| ); | ||
| return Command.empty(); | ||
| } | ||
| const isValidUal = await this.validationService.validateUal(blockchain, contract, tokenId); |
There was a problem hiding this comment.
do we need both isvalidual and isual?
There was a problem hiding this comment.
Hmmm it's more because of logs, that we can know why it failed
brkagithub
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.