-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit/Proofs Command Retry Mechanism Rework #2782
Merged
djordjekovac
merged 10 commits into
v6/develop
from
improvement/commit-proofs-retry-mechanism
Nov 14, 2023
Merged
Commit/Proofs Command Retry Mechanism Rework #2782
djordjekovac
merged 10 commits into
v6/develop
from
improvement/commit-proofs-retry-mechanism
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
u-hubar
commented
Nov 13, 2023
•
edited
Loading
edited
- Removed txs retry mechanism
- Added gasPrice to the command data for the commits/proofs
- Added mechanism to increase gasPrice on timeouts for commits/proofs commands retries
- Improved arguments formatting for txs debugging
… retry mechanism, added gasPrice to the command data for the commits/proofs, added mechanism to increase gasPrice on timeouts for commits/proofs commands retries
u-hubar
added
improvement
Improvements or enhancements to existing features
v6
Issue or development for OT-node version 6
labels
Nov 13, 2023
…mmand retry handler
…n to calculate sigHash of the function with given arguments (taking into account overloaded functions), fixed functionFragment search in the executeContractFunction
u-hubar
requested review from
branarakic,
djordjekovac,
NZT48 and
zeroxbt
as code owners
November 13, 2023 15:25
NZT48
requested review from
Mihajlo-Pavlovic
and removed request for
branarakic and
zeroxbt
November 14, 2023 10:41
NZT48
approved these changes
Nov 14, 2023
Mihajlo-Pavlovic
approved these changes
Nov 14, 2023
djordjekovac
approved these changes
Nov 14, 2023
This was referenced Nov 14, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvements or enhancements to existing features
v6
Issue or development for OT-node version 6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.