Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing await and folder existance check #2678

Merged
merged 1 commit into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "origintrail_node",
"version": "6.0.13+hotfix.1",
"version": "6.0.13+hotfix.2",
"description": "OTNode V6",
"main": "index.js",
"type": "module",
Expand Down
14 changes: 10 additions & 4 deletions src/service/pending-storage-service.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class PendingStorageService {
`Removing cached assertion for ual: ${ual} operation id: ${operationId} from file in ${repository} pending storage`,
);

const pendingAssertionPath = this.fileService.getPendingStorageDocumentPath(
const pendingAssertionPath = await this.fileService.getPendingStorageDocumentPath(
repository,
blockchain,
contract,
Expand All @@ -83,11 +83,17 @@ class PendingStorageService {
await this.fileService.removeFile(pendingAssertionPath);

const pendingStorageFolderPath = this.fileService.getParentDirectory(pendingAssertionPath);
const otherPendingAssertions = await this.fileService.readDirectory(
const pendingStorageFolderExists = await this.fileService.pathExists(
pendingStorageFolderPath,
);
if (otherPendingAssertions.length === 0) {
await this.fileService.removeFolder(pendingStorageFolderPath);

if (pendingStorageFolderExists) {
const otherPendingAssertions = await this.fileService.readDirectory(
pendingStorageFolderPath,
);
if (otherPendingAssertions.length === 0) {
await this.fileService.removeFolder(pendingStorageFolderPath);
}
}
}

Expand Down
Loading