Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP API versioning #2660

Merged
merged 23 commits into from
Aug 24, 2023
Merged

HTTP API versioning #2660

merged 23 commits into from
Aug 24, 2023

Conversation

u-hubar
Copy link
Member

@u-hubar u-hubar commented Aug 9, 2023

Description

Implementation of the HTTP API versioning and small improvements to make API-related logic more generalized.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@u-hubar
Reworked HTTP API router to support multiple API versions, made json-…
e2dc810 
…schema-service more generic, added /v1/info route
@u-hubar u-hubar added improvement Improvements or enhancements to existing features feature New features v6 Issue or development for OT-node version 6 labels Aug 9, 2023
@u-hubar u-hubar self-assigned this Aug 9, 2023
zeroxbt
zeroxbt suggested changes Aug 15, 2023
View reviewed changes
src/service/http-api-service.js Outdated Show resolved Hide resolved
src/service/http-api-service.js Outdated Show resolved Hide resolved
src/service/http-api-service.js Outdated Show resolved Hide resolved
src/service/http-api-service.js Outdated Show resolved Hide resolved
src/service/http-api-service.js Outdated Show resolved Hide resolved
src/service/json-schema-service.js Outdated Show resolved Hide resolved
@u-hubar u-hubar marked this pull request as ready for review August 17, 2023 08:34
brkagithub
brkagithub approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@brkagithub brkagithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me but still probably should get 2 more reviews as I am not a 100% familiar with how this part of ot node worked in the past

src/constants/constants.js Show resolved Hide resolved
@u-hubar u-hubar merged commit 8a8643d into v6/develop Aug 24, 2023
3 checks passed
@u-hubar u-hubar deleted the v6/api-versioning branch August 24, 2023 11:59
This was referenced Aug 28, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroxbt zeroxbt zeroxbt approved these changes

@brkagithub brkagithub brkagithub approved these changes

@NZT48 NZT48 NZT48 approved these changes

@branarakic branarakic Awaiting requested review from branarakic branarakic is a code owner

@djordjekovac djordjekovac Awaiting requested review from djordjekovac

@kotlarmilos kotlarmilos Awaiting requested review from kotlarmilos

Assignees

@u-hubar u-hubar

Labels
feature New features improvement Improvements or enhancements to existing features v6 Issue or development for OT-node version 6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@u-hubar @NZT48 @brkagithub @zeroxbt