Skip to content

Commit

Permalink
Merge pull request #2678 from OriginTrail/bugfix/get-and-finalization-2
Browse files Browse the repository at this point in the history
Added missing await and folder existance check
  • Loading branch information
NZT48 authored Aug 22, 2023
2 parents a2bed5a + 71d2349 commit 791acc7
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "origintrail_node",
"version": "6.0.13+hotfix.1",
"version": "6.0.13+hotfix.2",
"description": "OTNode V6",
"main": "index.js",
"type": "module",
Expand Down
14 changes: 10 additions & 4 deletions src/service/pending-storage-service.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class PendingStorageService {
`Removing cached assertion for ual: ${ual} operation id: ${operationId} from file in ${repository} pending storage`,
);

const pendingAssertionPath = this.fileService.getPendingStorageDocumentPath(
const pendingAssertionPath = await this.fileService.getPendingStorageDocumentPath(
repository,
blockchain,
contract,
Expand All @@ -83,11 +83,17 @@ class PendingStorageService {
await this.fileService.removeFile(pendingAssertionPath);

const pendingStorageFolderPath = this.fileService.getParentDirectory(pendingAssertionPath);
const otherPendingAssertions = await this.fileService.readDirectory(
const pendingStorageFolderExists = await this.fileService.pathExists(
pendingStorageFolderPath,
);
if (otherPendingAssertions.length === 0) {
await this.fileService.removeFolder(pendingStorageFolderPath);

if (pendingStorageFolderExists) {
const otherPendingAssertions = await this.fileService.readDirectory(
pendingStorageFolderPath,
);
if (otherPendingAssertions.length === 0) {
await this.fileService.removeFolder(pendingStorageFolderPath);
}
}
}

Expand Down

0 comments on commit 791acc7

Please sign in to comment.