-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java: make telemetry optional #244
base: master
Are you sure you want to change the base?
java: make telemetry optional #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me
Just one remark. This message isn't very clear. What do you think? |
By the way, what about Jaeger. |
Thanks for "catching" that ;) I'll correct it! |
Signed-off-by: Mathieu LEFEBVRE <[email protected]>
IoT3Core will now only attempt to instantiate the MQTT and OpenTelemetry clients if their parameters have been set with the builder's mqttParams(...) and telemetryParams(...) respectively, or if the builder's bootstrapConfig(...) has been used. Signed-off-by: Mathieu LEFEBVRE <[email protected]>
IoT3Mobility builder bootstrapConfig(...) now has an 'enableTelemetry' parameter. IoT3Mobility will now only call the IoT3Core telemetryParams(...) builder if its own builder's telemetryParams(...) or bootstrapConfig(...) with enabled telemetry has been called. Signed-off-by: Mathieu LEFEBVRE <[email protected]>
Signed-off-by: Mathieu LEFEBVRE <[email protected]>
This will make the returned boostrap error clearer in case of wrong input parameter. Signed-off-by: Mathieu LEFEBVRE <[email protected]>
f0912b1
to
597503f
Compare
Features;
Telemetry is now optional for the IoT3 Core and Mobility SDKs.
Closes #235
How to test
Iot3MobilityBootstrapExample
class in theexamples
module, and set appropriate values for the following fields:Iot3MobilityBootstrapExample
.Expected results:
ENABLE_TELEMETRY
is set totrue
.