[refactor] Reduce cognitive complexity from multiple return statements #228
Conversation
hydrosquall
force-pushed
the
refactor/reduce-code-complexity-models
branch
from
1cc56e9 to
06b18ff
Compare
hydrosquall
force-pushed
the
refactor/reduce-code-complexity-models
branch
from
06b18ff to
3b7a31c
Compare
| ( | ||
| getattr(self, attribute) | ||
| == getattr(other, attribute) | ||
| for attribute in [ |
There was a problem hiding this comment.
This looks like it might be less efficient because of the nested loop situation (I'm not sure how python actually interprets this, but it looks like a nested loop to me). However, in the interest of fixing the code complexity issue and because this looks more elegant and pythonic, I'm going to try to avoid premature optimization and go with it. Thanks 😄
There was a problem hiding this comment.
This is a good question! The outer loop is a generator, so it should only pull out the attributes from the inner loop 1 at a time. This means that if the first attribute test fails, the other attributes don't get tested as well.
There was a problem hiding this comment.
I'm open to coming back and optimizing this if needed in the future :)
There was a problem hiding this comment.
I think we're a little early to explore performance testing. Once we do, this might be an area we look at, but it all depends. For now, we need to get the front end coded up and possibly other clients like slackbot hooked into it before we'll have enough users to worry about performance.
Thanks for the offer 😄
There was a problem hiding this comment.
Ah, got it, just saw OperationCode/front-end#661. Is there a public API that can be pinged to test out this resource without using the Slackbot?
There was a problem hiding this comment.
I'm not sure if you mean to say "Where is the resources API deployed?" But that's the question I'm going to answer. https://resources.operationcode.org has the docs, follow them to use the API
There was a problem hiding this comment.
Ah, despite my awkward phrasing, you figured out the question that I had meant to ask. Thanks!
Overview
Removes 4 CodeClimate warnings about having many returns, and 1 warning about having high cyclomatic complexity, while preserving the same behavior. This was motivated by Fix Code Climate issues #82 .
Uses a generator so that the test will short-circuit if any of the earlier checks fail.
See https://codeclimate.com/github/OperationCode/resources_api/app/models.py/source#issue-a49e24d316f36fbe89761497d99f0928 for the warnings of interest.