Skip to content
This repository has been archived by the owner on Nov 15, 2018. It is now read-only.

17 make nightlife rabbet capture logs in a text file #20

Merged

Conversation

andySigler
Copy link
Contributor

This branch removes the console logging from the nightlife-rabbit WAMP router, and instead sends all router logs to router_logfile.txt inside the otone_data folder.

There are to changes to app/package.json's dependencies:

  1. nightlife-rabbit dependency points to an opentrons fork of the project, allowing custom loggers
  2. the nodejs logger winston is added to dependencies

@andySigler
Copy link
Contributor Author

@SimplyAhmazing @levthedev once this PR is merged, the electron app won't be filled with those nightlife-rabbit logs any more :)

@levthedev
Copy link
Contributor

I'm OK with this as long as the nightlife fork is necessary. But it looks like CLogger supports logging to a file - the only feature I can see that we need in Winston that's not in CLogger is the max file length thing. Have you looked into a way to do that with CLogger?

@andySigler
Copy link
Contributor Author

andySigler commented Aug 4, 2016

@lev I've looked into CLogger for a maxfile parameter and could not find one.

The fork of nightlife-rabbit is necessary, because the router's default logger was not able to be overwritten before, as brought up in this issue

@levthedev
Copy link
Contributor

ok then, LGTM 💯

@andySigler andySigler merged commit 688d5a3 into master Aug 4, 2016
@andySigler andySigler deleted the 17-make-nightlife-rabbet-capture-logs-in-a-text-file branch August 4, 2016 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants