Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): edit Thermocycler docstring notes #16952

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ecormany
Copy link
Contributor

Overview

I recently noticed that there was a syntax error that was hiding some notes in the docstrings for Thermocycler methods. I fixed the syntax in another PR and they became visible. But then I didn't like them! So this PR fixes them up.

Test Plan and Hands on Testing

Sandbox

Changelog

  • Remove note about specifying time for profile steps. Covered by parameter entry.
  • Transform note about run log behavior into a version changed statement.

Review requests

gtg?

Risk assessment

v low, docstrings

@ecormany ecormany requested a review from a team as a code owner November 22, 2024 16:20
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ecormany ecormany merged commit 7e09722 into edge Nov 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants