Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): address DQA for labware stacking work #16028

Merged
merged 3 commits into from
Aug 15, 2024
Merged

fix(app): address DQA for labware stacking work #16028

merged 3 commits into from
Aug 15, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 15, 2024 •
edited
Loading

Overview

Provide various design fixes following DQA for labware stacking.

Closes RQA-3017, RQA-3023

Test Plan and Hands on Testing

Desktop

  • Start run for protocol with stacked entities
  • Expand labware setup step
  • Verify that ToggleGroup for list/map view is updated to match designs as specified in tickets
  • Verify that list items are updated to match designs as specified in tickets
    image
    image

ODD

  • Start run for protocol with stacked entities
  • Click labware setup step > map view
  • Select stack to open LabwareStackModal and verify that spacing between header icons is 8px
    image

Changelog

  • update ToggleGroup style
  • fix SetupLabwareList left side width (fixed: 80px) and vertical spacing for right hand elements
  • update gridGap for ODD LabwareStackModal header DeckInfoLabels (stacked + slot)

Review requests

  • see test plan

Risk assessment

low

@ncdiehl11 ncdiehl11 self-assigned this Aug 15, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 15, 2024 21:14
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 15, 2024 21:14
@ncdiehl11 ncdiehl11 requested review from mjhuff, smb2268, brenthagen and a team and removed request for a team August 15, 2024 21:14
smb2268
smb2268 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm!

@ncdiehl11 ncdiehl11 merged commit 434f445 into chore_release-8.0.0 Aug 15, 2024
25 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-labwarestack-dqa branch August 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smb2268 smb2268 smb2268 approved these changes

@mjhuff mjhuff Awaiting requested review from mjhuff mjhuff is a code owner automatically assigned from Opentrons/js

@brenthagen brenthagen Awaiting requested review from brenthagen

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @smb2268